Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9982863
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -39,8 +42,9 @@ public PArrayDataType() {
if(object == null) {
throw new ConstraintViolationException(this + " may not
be null");
}
- int size = PDataType.fromTypeId((baseType.getSqlType() +
Types.ARRAY)).estimateByteSize(object);
-
+ Pair<Integer, Integer> nullsVsNullRepeationCounter = new
Pair<Integer, Integer>();
--- End diff --
Whatever is simpler and less code. Just a suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
