Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10064767
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -39,36 +49,64 @@ public PArrayDataType() {
if(object == null) {
throw new ConstraintViolationException(this + " may not
be null");
}
- int size = PDataType.fromTypeId((baseType.getSqlType() +
Types.ARRAY)).estimateByteSize(object);
-
+ Pair<Integer, Integer> nullsVsNullRepeationCounter = new
Pair<Integer, Integer>();
+ int size = estimateByteSize(object, nullsVsNullRepeationCounter,
+ PDataType.fromTypeId((baseType.getSqlType() +
Types.ARRAY)));
int noOfElements = ((PhoenixArray)object).numElements;
if(noOfElements == 0) {
return ByteUtil.EMPTY_BYTE_ARRAY;
}
- ByteBuffer buffer;
- int capacity = 0;
+
+ TrustedByteArrayOutputStream byteStream = null;
if (!baseType.isFixedWidth() ||
baseType.isCoercibleTo(PDataType.VARCHAR)) {
--- End diff --
We don't support CHAR as a primitive. An array of CHAR for us is an array
of single byte characters, so it's fixed width.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
