Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10113013
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -393,6 +393,73 @@ public void testSelectWithArrayWithColumnRef() throws
Exception {
}
--- End diff --
Can we make the logic of writing nulls as vint. In case of
ArrayConstructorExpression we need to know the actual size of the nulls because
we use ptr.set.
In the normal case where we create bytes from the Array i think we can
infer the max value of repeating nulls and use vint to create the byte size.
Because using byte any value more than the 127 would mean it would create
negative values. Also if there an array with 32 repeating null values and
another array with 287 repeating values would endup same because we would write
0 32 as the count. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
