Github user yaise commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/15#discussion_r10463695
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ---
@@ -119,7 +116,36 @@ private static Properties newPropsWithSCN(long scn,
Properties props) {
props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB,
Long.toString(scn));
return props;
}
-
--- End diff --
Let me know if the comments here don't make sense. Basically the joy of
using java.util.properties' copy constructor is that it doesn't do a deep copy
but holds a reference. getProperty() works but native map operations like
remove or containsKey only work on the map( i.e. this property instance) and
not the one it wraps. So if someone added tenant ID to properties, great ( we
can remove easily) but if someone added it to properties and then wrapped it in
another one, then we have to create a new copy and exclude it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
