Github user yaise commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/15#discussion_r10464447
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ---
@@ -119,7 +116,36 @@ private static Properties newPropsWithSCN(long scn,
Properties props) {
props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB,
Long.toString(scn));
return props;
}
-
--- End diff --
I had thought of a subclass of properties where I would just change the
copy constructor behavior and use this where appropriate . I can try that or a
util. It's more generic than this solution .
Although this solution nicely encapsulates tenant related changes to
phoenixConnection where it's really used. In case we add more tenant related
info that needs to stripped out ( or added ) in the future, this is the only
point of change
Somesh Sasalatti
[sent from my mobile device]
> On Mar 11, 2014, at 0:32, James Taylor <[email protected]> wrote:
>
> In
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java:
>
> > @@ -119,7 +116,36 @@ private static Properties newPropsWithSCN(long
scn, Properties props) {
> > props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB,
Long.toString(scn));
> > return props;
> > }
> > -
> Nice find. I'd rather keep things simple, though. I'm not worried about
creating a new Properties here. How about a util method that just instantiating
a new, empty constructor Properties and iterating through the entrySet of the
one passed through to just add the values? I'd rather do that then special case
tenantId.
>
> â
> Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
