-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/134/
-----------------------------------------------------------
(Updated 2010-12-01 13:43:29.058213)
Review request for pig.
Summary
-------
Change behavior of converting bytes loading from BinStorage.
1. Converting bytes loading from BinStorage() will now result an error.
2. If user clearly understand that the data is load from PigStorage (or other
LoadFunc using Utf8StorageConverter), he/she should use BinStorageWithCaster.
By doing this, converting bytes to other type will still work.
This addresses bug PIG-1745.
https://issues.apache.org/jira/browse/PIG-1745
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/builtin/BinStorage.java
1040653
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/builtin/BinStorageWithCaster.java
PRE-CREATION
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java
1040653
Diff: https://reviews.apache.org/r/134/diff
Testing (updated)
-------
test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
unit-test:
all pass
end-to-end test:
all pass
Thanks,
Daniel
