----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/544/#review382 -----------------------------------------------------------
Ship it! +1 - thejas On 2011-04-04 18:10:55, Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/544/ > ----------------------------------------------------------- > > (Updated 2011-04-04 18:10:55) > > > Review request for pig and thejas. > > > Summary > ------- > > The following script produce wrong result: > > data = LOAD 'data.txt' using PigStorage() as (referrer:chararray, > canonical_url:chararray, ip:chararray); > best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is > not null) ? canonical_url : referrer) AS url, ip; > filtered = FILTER best_url BY url == 'badsite.com'; > dump filtered; > > data.txt: > badsite.com 127.0.0.1 > goodsite.com/1?foo=true goodsite.com 127.0.0.1 > > Expected: > (badsite.com,127.0.0.1) > > We get nothing. > > > This addresses bug PIG-1935. > https://issues.apache.org/jira/browse/PIG-1935 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java > 1085215 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java > 1085215 > > Diff: https://reviews.apache.org/r/544/diff > > > Testing > ------- > > test-patch: > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > > Unit test: > all pass > > End-to-end test: > all pass > > > Thanks, > > Daniel > >
