[
https://issues.apache.org/jira/browse/PIG-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitriy V. Ryaboy updated PIG-2403:
-----------------------------------
Attachment: PIG-2403.patch
The attached patch extracts common code from max, sum, and min implementations
into a common base class and reuses it across the board. I'm not totally
satisfied -- a lot of boilerplate is still copy-pasted between the
long/int/float/double implementations, but it's a step in the right direction.
TestBuiltin passes.
Ready for review.
> Reduce code duplication in SUM, MAX, MIN udfs
> ---------------------------------------------
>
> Key: PIG-2403
> URL: https://issues.apache.org/jira/browse/PIG-2403
> Project: Pig
> Issue Type: Improvement
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.11
>
> Attachments: PIG-2403.patch
>
>
> The current type-specific implementations of Max, Min, and Sum have a lot of
> duplicated code. We can reduce this significantly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
