[
https://issues.apache.org/jira/browse/PIG-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168683#comment-13168683
]
Alan Gates commented on PIG-2403:
---------------------------------
I tried to review the patch, but I can't get it to apply. It says:
{code}
gates> patch -p0 < PIG-2403.patch
patching file src/org/apache/pig/builtin/AlgebraicByteArrayMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicDoubleMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicFloatMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicIntMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicLongMathBase.java
patching file src/org/apache/pig/builtin/AlgebraicMathBase.java
can't find file to patch at input line 1047
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git src/org/apache/pig/builtin/DoubleAbs.java
src/org/apache/pig/builtin/DoubleAbs.java
|index bac4861..79c6be8 100644
|--- src/org/apache/pig/builtin/DoubleAbs.java
|+++ src/org/apache/pig/builtin/DoubleAbs.java
--------------------------
File to patch:
{code}
It looks like maybe you used git diff without the --no-prefix option.
> Reduce code duplication in SUM, MAX, MIN udfs
> ---------------------------------------------
>
> Key: PIG-2403
> URL: https://issues.apache.org/jira/browse/PIG-2403
> Project: Pig
> Issue Type: Improvement
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Fix For: 0.11
>
> Attachments: PIG-2403.patch
>
>
> The current type-specific implementations of Max, Min, and Sum have a lot of
> duplicated code. We can reduce this significantly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
