We can put it into 0.10.1. IMO the only thing that should block a release, especially one that's been pending for so long, are major regressions (efficiency or functionality) or correctness issues. Things that didn't work before still not working is unfortunate but not a blocker.
(Also: this is why we should disconnect piggybank from pig releases...) D On Tue, Apr 24, 2012 at 4:58 PM, Russell Jurney <russell.jur...@gmail.com> wrote: > This bug was never fixed, and I'm assured AvroStrorage fails on large files > in a production context. Any chance I can write tests for the patch in > comments and get it in 0.10? > > https://issues.apache.org/jira/browse/PIG-2266 > > On Tue, Apr 24, 2012 at 4:01 PM, Dmitriy Ryaboy <dvrya...@gmail.com> wrote: > >> Heh. Ok my +1 stands. >> >> On Tue, Apr 24, 2012 at 3:25 PM, Alan Gates <ga...@hortonworks.com> wrote: >> > Oddly enough that's how we've always done the version numbering in the >> build file, setting it up for the next version. I agree we should change >> it, but since we've done it in every release since 0.1, I don't think we >> should block 0.10 for it. The change is to change the directions in >> HowToRelease. >> > >> > Alan. >> > >> > On Apr 24, 2012, at 3:16 PM, Dmitriy Ryaboy wrote: >> > >> >> That's a good catch. >> >> >> >> We shouldn't officially publish a "SNAPSHOT" build... >> >> >> >> Or does that get fixed only when you officially publish? Wouldn't the >> >> signature change? >> >> >> >> D >> >> >> >> On Tue, Apr 24, 2012 at 9:39 AM, Bill Graham <billgra...@gmail.com> >> wrote: >> >>> I'm working on getting through the unit tests, but should SNAPSHOT >> still be >> >>> in the version? >> >>> >> >>> $ grep SNAPSHOT build.xml >> >>> <property name="version" value="${pig.version}-SNAPSHOT" /> >> >>> >> >>> >> >>> On Tue, Apr 24, 2012 at 8:47 AM, Joseph Adler <joseph.ad...@gmail.com >> >wrote: >> >>> >> >>>> Can you guys please fix >> https://issues.apache.org/jira/browse/PIG-2266 >> >>>> >> >>>> Without that, I can guarantee that AvroStorage will fail on large >> files. >> >>>> >> >>>> On Mon, Apr 23, 2012 at 8:07 PM, Joseph Adler <joseph.ad...@me.com> >> wrote: >> >>>>> I will do it tomorrow on one of my workflows. Could take some trial >> and >> >>>> error to get it working. >> >>>>> >> >>>>> -- Joe >> >>>>> >> >>>>> On Apr 23, 2012, at 6:53 PM, Russell Jurney < >> russell.jur...@gmail.com> >> >>>> wrote: >> >>>>> >> >>>>>> Can someone from LinkedIn try this release candidate? It may break >> >>>>>> your AvroStorage, so that would be good to know. >> >>>>>> >> >>>>>> Russell Jurney http://datasyndrome.com >> >>>>>> >> >>>>>> On Apr 23, 2012, at 6:36 PM, Dmitriy Ryaboy <dvrya...@gmail.com> >> wrote: >> >>>>>> >> >>>>>>> +1 >> >>>>>>> >> >>>>>>> >> >>>>>>> Verified several jobs using Elephant-Bird loaders. >> >>>>>>> Tested correctness with pig.exec.mapPartAgg both true and false. >> >>>>>>> Verified license. >> >>>>>>> Verified release notes. >> >>>>>>> Ran test-commit >> >>>>>>> >> >>>>>>> D >> >>>>>>> >> >>>>>>> On Sat, Apr 21, 2012 at 12:27 PM, Daniel Dai < >> da...@hortonworks.com> >> >>>> wrote: >> >>>>>>>> We should do sanity check of the package, such as unit tests, e2e >> >>>>>>>> tests, piggybank tests, package integrity, package signature, >> license, >> >>>>>>>> etc. However, if we find a new bug, usually we will push it to the >> >>>>>>>> next release at this stage unless it is a critical one. >> >>>>>>>> >> >>>>>>>> Thanks, >> >>>>>>>> Daniel >> >>>>>>>> >> >>>>>>>> On Sat, Apr 21, 2012 at 12:48 AM, Prashant Kommireddi >> >>>>>>>> <prash1...@gmail.com> wrote: >> >>>>>>>>> Hi Daniel, >> >>>>>>>>> >> >>>>>>>>> What is required other than running the regular tests for testing >> >>>> release >> >>>>>>>>> candidate? I can think of running a few existing scripts against >> >>>> candidate >> >>>>>>>>> build and making sure outputs look fine. >> >>>>>>>>> >> >>>>>>>>> Thanks, >> >>>>>>>>> Prashant >> >>>>>>>>> >> >>>>>>>>> On Fri, Apr 20, 2012 at 12:39 AM, Daniel Dai < >> da...@hortonworks.com> >> >>>> wrote: >> >>>>>>>>> >> >>>>>>>>>> Hi, >> >>>>>>>>>> >> >>>>>>>>>> I have created a candidate build for Pig 0.10.0. >> >>>>>>>>>> >> >>>>>>>>>> Keys used to sign the release are available at >> >>>>>>>>>> http://svn.apache.org/viewvc/pig/trunk/KEYS?view=markup. >> >>>>>>>>>> >> >>>>>>>>>> Please download, test, and try it out: >> >>>>>>>>>> >> >>>>>>>>>> http://people.apache.org/~daijy/pig-0.10.0-candidate-0/ >> >>>>>>>>>> >> >>>>>>>>>> Should we release this? Vote closes on next Tuesday, Apr 24th. >> >>>>>>>>>> >> >>>>>>>>>> Daniel >> >>>>>>>>>> >> >>>> >> >>> >> >>> >> >>> >> >>> -- >> >>> *Note that I'm no longer using my Yahoo! email address. Please email >> me at >> >>> billgra...@gmail.com going forward.* >> > >> > > > > -- > Russell Jurney twitter.com/rjurney russell.jur...@gmail.com datasyndrome.com
