> On July 18, 2012, 2:56 a.m., Santhosh Srinivasan wrote: > > Needs more test cases to increase code coverage. There are no negative > > tests.
Thank you very much for reviewing my patch! I will add more tests as you suggested. > On July 18, 2012, 2:56 a.m., Santhosh Srinivasan wrote: > > contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java, > > line 69 > > <https://reviews.apache.org/r/5936/diff/1/?file=122600#file122600line69> > > > > What if you have test_glob{3,2,1}.avro - will the test case fail? No, it doesn't. The order doesn't matter. Nevertheless, I will add a test case for that. - Cheolsoo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5936/#review9233 ----------------------------------------------------------- On July 15, 2012, 2:51 a.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5936/ > ----------------------------------------------------------- > > (Updated July 15, 2012, 2:51 a.m.) > > > Review request for pig. > > > Description > ------- > > Add glob support to AvroStorage: > > https://issues.apache.org/jira/browse/PIG-2492 > > > This addresses bug PIG-2492. > https://issues.apache.org/jira/browse/PIG-2492 > > > Diffs > ----- > > > contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java > 0f8ef27 > > contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java > c7de726 > > contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java > 48b093b > > Diff: https://reviews.apache.org/r/5936/diff/ > > > Testing > ------- > > 1. Added new unit tests as follows: > > - testDir verifies that AvroStorage recursively loads files in a directory > and its sub-directories. > - testGlob1 to 3 verify that glob patterns are expanded properly. > > To run the tests, please do the following: > > wget > https://issues.apache.org/jira/secure/attachment/12536534/avro_test_files.tar.gz > > tar -xf avro_test_files.tar.gz > ant clean compile-test piggybank -Dhadoopversion=20 > cd contrib/piggybank/java > ant test -Dtestcase=TestAvroStorage > > 2. Both TestAvroStorage and TestAvroStorageUtils pass. > > > Thanks, > > Cheolsoo Park > >
