----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5936/ -----------------------------------------------------------
(Updated July 21, 2012, 10:27 p.m.) Review request for pig. Changes ------- It turned out that testGlob1 fails when the test .avro files are added by svn. This was because '*' matches every file including .svn. I fixed this problem by applying PATHP_FILTER to fs.globStatus() and confirmed that all tests pass even when test .avro files are added by svn. Thank you very much for finding this problem Santhosh! Description ------- Add glob support to AvroStorage: https://issues.apache.org/jira/browse/PIG-2492 This addresses bug PIG-2492. https://issues.apache.org/jira/browse/PIG-2492 Diffs (updated) ----- contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 0f8ef27 contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java c7de726 contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 48b093b contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorageUtils.java e5d0c38 Diff: https://reviews.apache.org/r/5936/diff/ Testing ------- 1. Added new unit tests as follows: - testDir verifies that AvroStorage recursively loads files in a directory and its sub-directories. - testGlob1 to 3 verify that glob patterns are expanded properly. To run the tests, please do the following: wget https://issues.apache.org/jira/secure/attachment/12536534/avro_test_files.tar.gz tar -xf avro_test_files.tar.gz ant clean compile-test piggybank -Dhadoopversion=20 cd contrib/piggybank/java ant test -Dtestcase=TestAvroStorage 2. Both TestAvroStorage and TestAvroStorageUtils pass. Thanks, Cheolsoo Park
