----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17087/#review32528 -----------------------------------------------------------
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java <https://reviews.apache.org/r/17087/#comment61401> How about holding a classname + hashcode in map instead of object? Makes me a little nervous by holding a reference of the object. src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java <https://reviews.apache.org/r/17087/#comment61400> Why not LoadFunc/StoreFunc? - Daniel Dai On Jan. 22, 2014, 7:24 p.m., Aniket Mokashi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17087/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 7:24 p.m.) > > > Review request for pig, Cheolsoo Park, Daniel Dai, and Thejas Nair. > > > Bugs: PIG-2207 > https://issues.apache.org/jira/browse/PIG-2207 > > > Repository: pig-git > > > Description > ------- > > - Grouped counters for udfs > - Log at least once. > > > Diffs > ----- > > > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java > 6842b10 > > Diff: https://reviews.apache.org/r/17087/diff/ > > > Testing > ------- > > > Thanks, > > Aniket Mokashi > >
