> On Jan. 22, 2014, 8:22 p.m., Daniel Dai wrote: > > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java, > > line 66 > > <https://reviews.apache.org/r/17087/diff/1/?file=429825#file429825line66> > > > > How about holding a classname + hashcode in map instead of object? > > Makes me a little nervous by holding a reference of the object.
I'm using WeakHashMap (the presence of a mapping for a given key will not prevent the key from being discarded by the garbage collector), so this should be fine. > On Jan. 22, 2014, 8:22 p.m., Daniel Dai wrote: > > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java, > > line 68 > > <https://reviews.apache.org/r/17087/diff/1/?file=429825#file429825line68> > > > > Why not LoadFunc/StoreFunc? LoadFunc/StoreFunc have their own ways of reporting warnings (https://github.com/apache/pig/blob/trunk/src/org/apache/pig/LoadFunc.java#L304). None of those call into PigHadoopLogger. We could have a separate jira to consolidate those. - Aniket ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17087/#review32528 ----------------------------------------------------------- On Jan. 22, 2014, 7:24 p.m., Aniket Mokashi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17087/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 7:24 p.m.) > > > Review request for pig, Cheolsoo Park, Daniel Dai, and Thejas Nair. > > > Bugs: PIG-2207 > https://issues.apache.org/jira/browse/PIG-2207 > > > Repository: pig-git > > > Description > ------- > > - Grouped counters for udfs > - Log at least once. > > > Diffs > ----- > > > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigHadoopLogger.java > 6842b10 > > Diff: https://reviews.apache.org/r/17087/diff/ > > > Testing > ------- > > > Thanks, > > Aniket Mokashi > >
