[
https://issues.apache.org/jira/browse/PIG-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nezih Yigitbasi updated PIG-259:
--------------------------------
Attachment: PIG-259.8.patch
When I removed the isOverwritable method tests failed. Because, the user tells
us whether to overwrite or not, and using that flag we determine to catch file
not found problems during validation. That is, implementing the interface is
not enough to catch file not found problems during validation (user says
"-overwrite false" but we only check whether PigStorage implements the
OverwritingStoreFunc and ignore his input), so we need a flag that tells us
user's input. To make the intent clearer I changed the name of
OverwritingStoreFunc to OverwritableStoreFunc and changed the name of the
method from "isOverwrite" to "shouldOverwrite", also added some javadoc.
> allow store to overwrite existing directroy
> -------------------------------------------
>
> Key: PIG-259
> URL: https://issues.apache.org/jira/browse/PIG-259
> Project: Pig
> Issue Type: Sub-task
> Reporter: Olga Natkovich
> Assignee: Nezih Yigitbasi
> Fix For: 0.13.0
>
> Attachments: PIG-259.5.patch, PIG-259.6.patch, PIG-259.7.patch,
> PIG-259.8.patch, Pig_259.patch, Pig_259_2.patch, Pig_259_3.patch,
> Pig_259_4.patch
>
>
> we have users who are asking for a flag to overwrite existing directory
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
