> On Feb. 26, 2014, 7:06 p.m., Rohini Palaniswamy wrote: > > src/org/apache/pig/impl/util/Utils.java, line 605 > > <https://reviews.apache.org/r/18505/diff/1/?file=504084#file504084line605> > > > > Just to know, is it the _SUCCESS files that you are trying to filter > > out? > > > > If so can the method be renamed to getSuccessMarkerPathFilter? > > > > Also can we add the method to org.apache.pig.test.Util in test package > > instead of this class?
Yes, that's exactly what I am doing. I incorporated your suggestions. > On Feb. 26, 2014, 7:06 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestAccumulator.java, line 65 > > <https://reviews.apache.org/r/18505/diff/1/?file=504085#file504085line65> > > > > Why don't we set this in MiniCluster m_conf itself. Once we fix the > > original issue, then it will just be one place that needs to be fixed. Good suggestion. Done. > On Feb. 26, 2014, 7:06 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/data/GoldenFiles/TEZC11.gld, line 58 > > <https://reviews.apache.org/r/18505/diff/1/?file=504091#file504091line58> > > > > Combiner has gone missing. We need to fix this instead of changing > > golden file. Can you leave this file as is? Good catch and reverted. I'll open a jira for TestTezCompiler failures. > On Feb. 26, 2014, 7:06 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/data/GoldenFiles/TEZC7.gld, line 5 > > <https://reviews.apache.org/r/18505/diff/1/?file=504102#file504102line5> > > > > I think this one should be left as is till PIG-3757 is fully done. Reverted. > On Feb. 26, 2014, 7:06 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/data/GoldenFiles/TEZC8.gld, lines 31-33 > > <https://reviews.apache.org/r/18505/diff/1/?file=504103#file504103line31> > > > > This one also be left as is till PIG-3757 is fully done. The filter > > should not be there. Reverted. > On Feb. 26, 2014, 7:06 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/data/GoldenFiles/TEZC9.gld, line 51 > > <https://reviews.apache.org/r/18505/diff/1/?file=504104#file504104line51> > > > > This one also be left as is till PIG-3757 is fully done. Reverted. - Cheolsoo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18505/#review35548 ----------------------------------------------------------- On Feb. 26, 2014, 2:13 a.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18505/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 2:13 a.m.) > > > Review request for pig, Daniel Dai and Rohini Palaniswamy. > > > Bugs: PIG-3780 > https://issues.apache.org/jira/browse/PIG-3780 > > > Repository: pig-git > > > Description > ------- > > Fixing unit tests in tez branch. Please see the details in the jira- > https://issues.apache.org/jira/browse/PIG-3780 > > > Diffs > ----- > > src/org/apache/pig/impl/util/Utils.java b38161f > test/org/apache/pig/test/TestAccumulator.java 428bc0e > test/org/apache/pig/test/TestCombiner.java a597543 > test/org/apache/pig/test/TestCustomPartitioner.java 6659518 > test/org/apache/pig/test/TestSkewedJoin.java 54fb4f6 > test/org/apache/pig/test/TestSplitStore.java 68e2b39 > test/org/apache/pig/test/data/GoldenFiles/TEZC1.gld 43ec93b > test/org/apache/pig/test/data/GoldenFiles/TEZC11.gld 5159d4c > test/org/apache/pig/test/data/GoldenFiles/TEZC12.gld 4835f87 > test/org/apache/pig/test/data/GoldenFiles/TEZC14.gld aa862a5 > test/org/apache/pig/test/data/GoldenFiles/TEZC15.gld 121d5c5 > test/org/apache/pig/test/data/GoldenFiles/TEZC16.gld 85ea020 > test/org/apache/pig/test/data/GoldenFiles/TEZC17.gld 45fff59 > test/org/apache/pig/test/data/GoldenFiles/TEZC2.gld 0b43b01 > test/org/apache/pig/test/data/GoldenFiles/TEZC3.gld fc3b874 > test/org/apache/pig/test/data/GoldenFiles/TEZC4.gld 884f62d > test/org/apache/pig/test/data/GoldenFiles/TEZC5.gld 73cc8fe > test/org/apache/pig/test/data/GoldenFiles/TEZC6.gld e48b754 > test/org/apache/pig/test/data/GoldenFiles/TEZC7.gld 21d7053 > test/org/apache/pig/test/data/GoldenFiles/TEZC8.gld 86c09c2 > test/org/apache/pig/test/data/GoldenFiles/TEZC9.gld 2c146cd > test/org/apache/pig/tez/TestTezCompiler.java a3f3bab > > Diff: https://reviews.apache.org/r/18505/diff/ > > > Testing > ------- > > > Thanks, > > Cheolsoo Park > >
