> On Feb. 26, 2014, 10:06 p.m., Prashant Kommireddi wrote: > > test/org/apache/pig/test/Util.java, line 1279 > > <https://reviews.apache.org/r/18505/diff/2/?file=504895#file504895line1279> > > > > Hey Cheolsoo, I am in "observe" mode only and not really reviewing this > > code. Had a question however - is the behavior here supposed to be to > > ignore only file/dirnames starting with "_" and not a period "." > > > > Regarding the naming of this method - should the method rather be > > called getNonSuccessMarkerPathFilter ?
Hey Prashant, thanks for your comment. 1) Filenames that starts with "." weren't an issue for me at least when reading a final output dir. We could easily add it in the future if needed. 2) I don't have any preference between those two names. My interpretation of getSuccessMarkerPathFilter() is "get a PathFilter that filters out success marker". But I agree that you could interpret it differently. - Cheolsoo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18505/#review35570 ----------------------------------------------------------- On Feb. 26, 2014, 9:43 p.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18505/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 9:43 p.m.) > > > Review request for pig, Daniel Dai and Rohini Palaniswamy. > > > Bugs: PIG-3780 > https://issues.apache.org/jira/browse/PIG-3780 > > > Repository: pig-git > > > Description > ------- > > Fixing unit tests in tez branch. Please see the details in the jira- > https://issues.apache.org/jira/browse/PIG-3780 > > > Diffs > ----- > > shims/test/hadoop23/org/apache/pig/test/TezMiniCluster.java 72db43f > test/org/apache/pig/test/TestAccumulator.java 428bc0e > test/org/apache/pig/test/TestCombiner.java a597543 > test/org/apache/pig/test/TestCustomPartitioner.java 6659518 > test/org/apache/pig/test/TestSkewedJoin.java 54fb4f6 > test/org/apache/pig/test/TestSplitStore.java 68e2b39 > test/org/apache/pig/test/Util.java f03d145 > test/org/apache/pig/test/data/GoldenFiles/TEZC1.gld 43ec93b > test/org/apache/pig/test/data/GoldenFiles/TEZC12.gld 4835f87 > test/org/apache/pig/test/data/GoldenFiles/TEZC14.gld aa862a5 > test/org/apache/pig/test/data/GoldenFiles/TEZC15.gld 121d5c5 > test/org/apache/pig/test/data/GoldenFiles/TEZC16.gld 85ea020 > test/org/apache/pig/test/data/GoldenFiles/TEZC17.gld 45fff59 > test/org/apache/pig/test/data/GoldenFiles/TEZC2.gld 0b43b01 > test/org/apache/pig/test/data/GoldenFiles/TEZC3.gld fc3b874 > test/org/apache/pig/test/data/GoldenFiles/TEZC4.gld 884f62d > test/org/apache/pig/test/data/GoldenFiles/TEZC5.gld 73cc8fe > test/org/apache/pig/test/data/GoldenFiles/TEZC6.gld e48b754 > test/org/apache/pig/tez/TestTezCompiler.java a3f3bab > > Diff: https://reviews.apache.org/r/18505/diff/ > > > Testing > ------- > > > Thanks, > > Cheolsoo Park > >
