[ 
https://issues.apache.org/jira/browse/PIG-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907111#comment-14907111
 ] 

Rohini Palaniswamy commented on PIG-4684:
-----------------------------------------

Few comments:
  1) Log the stacktrace
  log.warn("Unable to get job related diagnostics"); ->  log.warn("Unable to 
get job related diagnostics", e);
  2) Need to still throw an exception if not able to fetch it.

{code}
} catch (Exception e) {
             throw new ExecException(e);
}
if (job.getState() != Job.SUCCESS) {
     throw new ExecException("Unable to retrieve exception from the failed job 
" + job.getMapredJobId() + ". Check the job directly for actual error", 2997, 
PigException.BUG);
 }
{code}

> Exception should be changed to warning when job diagnostics cannot be fetched
> -----------------------------------------------------------------------------
>
>                 Key: PIG-4684
>                 URL: https://issues.apache.org/jira/browse/PIG-4684
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.11.1
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: PIG-4684.1.patch
>
>
> When a job completes and there is a problem fetching the taskReports, 
> exception is thrown if the job has failed and a warning message if the job 
> has succeeded. The exception should not be thrown as the failure to get the 
> taskReports is not same as job failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to