[ 
https://issues.apache.org/jira/browse/PIG-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977083#comment-14977083
 ] 

Daniel Dai commented on PIG-4417:
---------------------------------

Ok, I am fine to add this. Several minor comments:
1. Config ARTIFACT_DOWNLOAD_LOCATION should be through pig.properties rather 
than environment variable as Pig convention (using 
pigServer.getPigContext().getProperties() to retrieve)
2. If ivysettings.xml is required, wrap it into pig-core.jar. Otherwise, if 
user don't install pig distribution, they will not get it
3. Need to add ivy.jar and groovy.jar into pig-template.xml
4. Better to add a couple of e2e tests (I can help if you need)

> Pig's register command should support automatic fetching of jars from repo.
> ---------------------------------------------------------------------------
>
>                 Key: PIG-4417
>                 URL: https://issues.apache.org/jira/browse/PIG-4417
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Akshay Rai
>            Assignee: Akshay Rai
>         Attachments: PIG-4417.1.patch, PIG-4417.2.patch
>
>
> Currently Pig's register command takes a local path to a dependency jar . 
> This clutters the local file-system as users may forget to remove this jar 
> later.
> It would be nice if Pig supported a Gradle like notation to download the jar 
> from a repository.
> Ex: At the top of the Pig script a user could add
> register '<group>:<module>:<version>'; 
> It should be backward compatible and should support a local file path if so 
> desired.
> RB: https://reviews.apache.org/r/31662/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to