Jackie-Jiang commented on a change in pull request #3535: Optimize all filter
predicates by adding isAlwaysTrue()
URL: https://github.com/apache/incubator-pinot/pull/3535#discussion_r235538397
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/operator/filter/AndFilterOperator.java
##########
@@ -28,6 +28,7 @@
private final List<BaseFilterOperator> _filterOperators;
public AndFilterOperator(List<BaseFilterOperator> filterOperators) {
+ // NOTE: EmptyFilterOperator and MatchAllFilterOperator should not be
passed into the AndFilterOperator
Review comment:
We can handle them, but we should not pass them in per performance concern
(actually we won't pass them in because re-order operators won't take these 2
operators). I just added this comment for clarification. Will add more details
to the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
