Jackie-Jiang commented on a change in pull request #3535: Optimize all filter
predicates by adding isAlwaysTrue()
URL: https://github.com/apache/incubator-pinot/pull/3535#discussion_r235538828
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/operator/filter/BitmapBasedFilterOperator.java
##########
@@ -42,6 +42,8 @@
public BitmapBasedFilterOperator(PredicateEvaluator predicateEvaluator,
DataSource dataSource, int startDocId,
int endDocId) {
+ // NOTE: predicate that is always false or true should not be passed into
the ScanBasedFilterOperator
Review comment:
We can handle it, but we should not pass them in for performance concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
