mcvsubbu commented on a change in pull request #3543: Segment merge lineage data structure URL: https://github.com/apache/incubator-pinot/pull/3543#discussion_r236421453
########## File path: pinot-common/src/main/java/com/linkedin/pinot/common/lineage/SegmentMergeLineage.java ########## @@ -0,0 +1,313 @@ +/** + * Copyright (C) 2014-2018 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.linkedin.pinot.common.lineage; + +import com.linkedin.pinot.common.exception.InvalidConfigException; +import com.linkedin.pinot.common.utils.EqualityUtils; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import org.apache.helix.ZNRecord; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Class to represent segment merge lineage information + */ +public class SegmentMergeLineage { + + private static final Logger LOGGER = LoggerFactory.getLogger(SegmentMergeLineage.class); + + private static final String LEVEL_KEY_PREFIX = "level_"; Review comment: Can you write some comments on what these keys mean, preferably with some examples? I like the documentation next to the key definition, but if there are other places in which this is documented,a pointer will help, thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
