mcvsubbu commented on a change in pull request #3543: Segment merge lineage data structure URL: https://github.com/apache/incubator-pinot/pull/3543#discussion_r238485595
########## File path: pinot-common/src/test/java/com/linkedin/pinot/common/lineage/SegmentMergeLineageTest.java ########## @@ -0,0 +1,106 @@ +/** + * Copyright (C) 2014-2018 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.linkedin.pinot.common.lineage; + +import com.linkedin.pinot.common.exception.InvalidConfigException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashSet; +import java.util.List; +import org.testng.Assert; +import org.testng.annotations.Test; + + +public class SegmentMergeLineageTest { + + @Test + public void testSegmentMergeLineage() throws Exception { + SegmentMergeLineage segmentMergeLineage = new SegmentMergeLineage("test_OFFLINE"); + String groupId1 = "G1"; + List<String> groupSegments1 = Arrays.asList(new String[]{"segment1", "segment2", "segment3"}); + segmentMergeLineage.addSegmentGroup(groupId1, groupSegments1, null); + Assert.assertEquals(segmentMergeLineage.getSegmentsForGroup(groupId1), groupSegments1); + + String groupId2 = "G2"; + List<String> groupSegments2 = Arrays.asList(new String[]{"segment4", "segment5"}); + segmentMergeLineage.addSegmentGroup(groupId2, groupSegments2, null); + Assert.assertEquals(segmentMergeLineage.getSegmentsForGroup(groupId2), groupSegments2); + + String groupId3 = "G3"; + List<String> groupSegments3 = Arrays.asList(new String[]{"segment6"}); + segmentMergeLineage.addSegmentGroup(groupId3, groupSegments3, Arrays.asList(new String[]{groupId1, groupId2})); + Assert.assertEquals(segmentMergeLineage.getSegmentsForGroup(groupId3), groupSegments3); + + // Check available APIs + Assert.assertEquals(segmentMergeLineage.getTableName(), "test_OFFLINE"); + Assert.assertEquals(segmentMergeLineage.getChildrenForGroup(groupId3), + Arrays.asList(new String[]{groupId1, groupId2})); + Assert.assertEquals(segmentMergeLineage.getAllGroupLevels(), Arrays.asList(new Integer[]{0, 1})); + Assert.assertTrue(segmentMergeLineage.equals(SegmentMergeLineage.fromZNRecord(segmentMergeLineage.toZNRecord()))); + Assert.assertEquals(segmentMergeLineage.getGroupIdsForGroupLevel(0), + Arrays.asList(new String[]{groupId1, groupId2})); + Assert.assertEquals(segmentMergeLineage.getGroupIdsForGroupLevel(1), + Arrays.asList(new String[]{groupId3})); + validateSegmentGroup(segmentMergeLineage); + + // Check ZNRecord conversion + Assert.assertEquals(segmentMergeLineage, SegmentMergeLineage.fromZNRecord(segmentMergeLineage.toZNRecord())); + + // Test removing groups + segmentMergeLineage.removeSegmentGroup(groupId1); + Assert.assertNull(segmentMergeLineage.getChildrenForGroup(groupId1)); + Assert.assertNull(segmentMergeLineage.getSegmentsForGroup(groupId1)); + Assert.assertFalse(segmentMergeLineage.getGroupIdsForGroupLevel(0).contains(groupId1)); + } + + @Test(expectedExceptions = InvalidConfigException.class) Review comment: The problem with expected exceptions is that it will pass the test if the exception happens anywhere in the test. I prefer checking for specific exception with a try/catch where we expect the exception. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
