snleee commented on a change in pull request #3543: Segment merge lineage data structure URL: https://github.com/apache/incubator-pinot/pull/3543#discussion_r237959372
########## File path: pinot-common/src/main/java/com/linkedin/pinot/common/lineage/SegmentMergeLineage.java ########## @@ -0,0 +1,313 @@ +/** + * Copyright (C) 2014-2018 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.linkedin.pinot.common.lineage; + +import com.linkedin.pinot.common.exception.InvalidConfigException; +import com.linkedin.pinot.common.utils.EqualityUtils; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import org.apache.helix.ZNRecord; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Class to represent segment merge lineage information + */ +public class SegmentMergeLineage { + + private static final Logger LOGGER = LoggerFactory.getLogger(SegmentMergeLineage.class); + + private static final String LEVEL_KEY_PREFIX = "level_"; + private static final String ROOT_NODE_GROUP_ID = "root"; + private static final String SEGMENT_DELIMITER = ","; + private static final int DEFAULT_GROUP_LEVEL = 0; + + private String _tableNameWithType; + private Map<String, List<String>> _parentGroupToChildrenGroupsMap; + private Map<Integer, Map<String, List<String>>> _levelToGroupToSegmentsMap; + + public SegmentMergeLineage(String tableNameWithType) { + _tableNameWithType = tableNameWithType; + _parentGroupToChildrenGroupsMap = new HashMap<>(); + _levelToGroupToSegmentsMap = new HashMap<>(); + } + + public SegmentMergeLineage(String tableNameWithType, Map<String, List<String>> segmentGroupLineageMap, + Map<Integer, Map<String, List<String>>> levelToGroupToSegmentMap, int version) { + _tableNameWithType = tableNameWithType; + _parentGroupToChildrenGroupsMap = segmentGroupLineageMap; + _levelToGroupToSegmentsMap = levelToGroupToSegmentMap; + } + + public String getTableName() { + return _tableNameWithType; + } + + public static SegmentMergeLineage fromZNRecord(ZNRecord record) { + String tableNameWithType = record.getId(); + int version = record.getVersion(); + Map<String, List<String>> segmentGroupLineageMap = record.getListFields(); + + Map<Integer, Map<String, List<String>>> groupToSegmentsMap = new HashMap<>(); + for (Map.Entry<String, Map<String, String>> entry : record.getMapFields().entrySet()) { + String levelKey = entry.getKey(); + Integer level = Integer.parseInt(levelKey.substring(LEVEL_KEY_PREFIX.length())); + Map<String, List<String>> groupToSegmentsForLevel = new HashMap<>(); + for (Map.Entry<String, String> groupEntry : entry.getValue().entrySet()) { + String groupId = groupEntry.getKey(); + String segmentsString = groupEntry.getValue(); + List<String> segments = Arrays.asList(segmentsString.split(SEGMENT_DELIMITER)); + groupToSegmentsForLevel.put(groupId, new ArrayList<>(segments)); + } + groupToSegmentsMap.put(level, groupToSegmentsForLevel); + } + return new SegmentMergeLineage(tableNameWithType, segmentGroupLineageMap, groupToSegmentsMap, version); + } + + public ZNRecord toZNRecord() { + ZNRecord record = new ZNRecord(_tableNameWithType); + record.setListFields(_parentGroupToChildrenGroupsMap); + Map<String, Map<String, String>> groupToSegmentsMap = new HashMap<>(); + + for (Map.Entry<Integer, Map<String, List<String>>> entry : _levelToGroupToSegmentsMap.entrySet()) { + String key = LEVEL_KEY_PREFIX + entry.getKey(); + Map<String, String> groupSegmentsForLevel = new HashMap<>(); + for (Map.Entry<String, List<String>> groupEntry : entry.getValue().entrySet()) { + String groupId = groupEntry.getKey(); + String segments = String.join(SEGMENT_DELIMITER, groupEntry.getValue()); + groupSegmentsForLevel.put(groupId, segments); + } + groupToSegmentsMap.put(key, groupSegmentsForLevel); + } + record.setMapFields(groupToSegmentsMap); + + return record; + } + + /** + * Add segment merge lineage information + * + * @param groupId a group id + * @param currentGroupSegments a list of segments that belongs to the group + * @param childrenGroups a list of children groups that the current group covers + */ + public void addSegmentGroup(String groupId, List<String> currentGroupSegments, List<String> childrenGroups) Review comment: `addSegmentGroup` will be called in 2 places. 1. Regular segment upload (via pbnj) : for original segments, we keep the group level 0 with `children = null`. 2. Minion merge task calling Controller API(will be added with the other pr): in this case, minion job needs to provide the children groups and call controller api to update segment merge lineage. I tried to keep API parameter as simple as possible because the minion task has limited information (although we can pass more information to task as task config). I think that we can revisit this issue for the pr for controller api. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
