snleee commented on a change in pull request #3543: Segment merge lineage data structure URL: https://github.com/apache/incubator-pinot/pull/3543#discussion_r238497015
########## File path: pinot-common/src/main/java/com/linkedin/pinot/common/lineage/SegmentMergeLineageAccessHelper.java ########## @@ -0,0 +1,82 @@ +/** + * Copyright (C) 2014-2018 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.linkedin.pinot.common.lineage; + +import com.linkedin.pinot.common.metadata.ZKMetadataProvider; +import com.linkedin.pinot.common.utils.retry.RetryPolicies; +import com.linkedin.pinot.common.utils.retry.RetryPolicy; +import java.util.List; +import org.apache.helix.AccessOption; +import org.apache.helix.PropertyPathConfig; +import org.apache.helix.PropertyType; +import org.apache.helix.ZNRecord; +import org.apache.helix.manager.zk.ZKHelixAdmin; +import org.apache.helix.manager.zk.ZNRecordSerializer; +import org.apache.helix.store.zk.ZkHelixPropertyStore; +import org.apache.zookeeper.data.Stat; + + +/** + * Class to help to read, write segment merge lineage + */ +public class SegmentMergeLineageAccessHelper { + + /** + * Read the segment merge lineage ZNRecord from the property store + * + * @param propertyStore a property store + * @param tableNameWithType a table name with type + * @return a ZNRecord of segment merge lineage + */ + public static ZNRecord getSegmentMergeLineageZNRecord(ZkHelixPropertyStore<ZNRecord> propertyStore, + String tableNameWithType) { + String path = ZKMetadataProvider.constructPropertyStorePathForSegmentMergeLineage(tableNameWithType); + Stat stat = new Stat(); + ZNRecord segmentMergeLineageZNRecord = propertyStore.get(path, stat, AccessOption.PERSISTENT); + if (segmentMergeLineageZNRecord != null) { + segmentMergeLineageZNRecord.setVersion(stat.getVersion()); + } + return segmentMergeLineageZNRecord; + } + + /** + * Read the segment merge lineage from the property store + * + * @param propertyStore a property store + * @param tableNameWithType a table name with type + * @return a segment merge lineage + */ + public static SegmentMergeLineage getSegmentMergeLineage(ZkHelixPropertyStore<ZNRecord> propertyStore, + String tableNameWithType) { + String path = ZKMetadataProvider.constructPropertyStorePathForSegmentMergeLineage(tableNameWithType); Review comment: fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
