kishoreg commented on a change in pull request #3568: Add guava cache to cache
table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#discussion_r238070515
##########
File path:
pinot-broker/src/main/java/com/linkedin/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -181,7 +195,7 @@ public BrokerResponse handleRequest(JSONObject request,
@Nullable RequesterIdent
// Validate the request
try {
- validateRequest(brokerRequest);
+ validateRequest(brokerRequest, request);
Review comment:
can we parse the json request into a concrete class e.g. RequestParams. This
will avoid having constant strings everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
