kishoreg commented on a change in pull request #3568: Add guava cache to cache
table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#discussion_r238070246
##########
File path:
pinot-broker/src/main/java/com/linkedin/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -120,6 +122,11 @@ public HelixBrokerStarter(String brokerHost, String
helixClusterName, String zkS
_helixExternalViewBasedRouting = new
HelixExternalViewBasedRouting(_propertyStore, _spectatorHelixManager,
pinotHelixProperties.subset(ROUTING_TABLE_PARAMS_SUBSET_KEY));
_tableQueryQuotaManager = new
TableQueryQuotaManager(_spectatorHelixManager);
+ _tableSchemaCache = new TableSchemaCache(_propertyStore,
+
_pinotHelixProperties.getInt(CommonConstants.Broker.CONFIG_OF_TABLE_SCHEMA_MAXIMUM_CACHE_SIZE,
Review comment:
none of these configs are useful. If we go beyond cache size, we will be
hitting ZK for every call
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
