snleee commented on a change in pull request #3584: add kafka simple consumer
buffer and timeout to stream config
URL: https://github.com/apache/incubator-pinot/pull/3584#discussion_r238867483
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/realtime/impl/kafka/KafkaLowLevelStreamConfig.java
##########
@@ -53,12 +65,36 @@ public String getBootstrapHosts() {
return _bootstrapHosts;
}
+ public int getKafkaBufferSize() {
+ return _kafkaBufferSize;
+ }
+
+ public int getKafkaSocketTimeout() {
+ return _kafkaSocketTimeout;
+ }
+
+ private int getConfigWithDefault(Map<String, String> configMap, String key,
int defaultValue) {
Review comment:
I think that it's better to indicate `int` to the function name since this
is specific to getting an int value. e.g. `getIntConfigWithDefault`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
