snleee commented on a change in pull request #3584: add kafka simple consumer
buffer and timeout to stream config
URL: https://github.com/apache/incubator-pinot/pull/3584#discussion_r238869666
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/realtime/impl/kafka/KafkaPartitionLevelConsumer.java
##########
@@ -45,6 +46,11 @@ public KafkaPartitionLevelConsumer(String clientId,
StreamConfig streamConfig, i
super(clientId, streamConfig, partition, kafkaSimpleConsumerFactory);
}
+ @VisibleForTesting
Review comment:
I think that this function should locate in the base class that defines
`simpleConsumer`. Can we move this to `KafkaConnectionHandler`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
