codecov-io edited a comment on issue #3604: Add ControllerLeadershipManager as single place to check controller leadership changes URL: https://github.com/apache/incubator-pinot/pull/3604#issuecomment-446061000 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3604?src=pr&el=h1) Report > Merging [#3604](https://codecov.io/gh/apache/incubator-pinot/pull/3604?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/a899cf4e610d534035f2def4f5ab3550eb484295?src=pr&el=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `70.49%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3604?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3604 +/- ## ============================================ - Coverage 70.91% 70.79% -0.13% Complexity 4 4 ============================================ Files 1009 1010 +1 Lines 46294 46330 +36 Branches 6208 6210 +2 ============================================ - Hits 32829 32798 -31 - Misses 11298 11373 +75 + Partials 2167 2159 -8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3604?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvUGlub3RIZWxpeFJlc291cmNlTWFuYWdlci5qYXZh) | `59.85% <ø> (-0.05%)` | `0 <0> (ø)` | | | [...not/controller/validation/StorageQuotaChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vU3RvcmFnZVF1b3RhQ2hlY2tlci5qYXZh) | `73.33% <0%> (-1%)` | `0 <0> (ø)` | | | [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVhbHRpbWUvUGlub3RMTENSZWFsdGltZVNlZ21lbnRNYW5hZ2VyLmphdmE=) | `73.07% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2suamF2YQ==) | `97.22% <100%> (+0.07%)` | `0 <0> (ø)` | :arrow_down: | | [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVhbHRpbWUvUGlub3RSZWFsdGltZVNlZ21lbnRNYW5hZ2VyLmphdmE=) | `73.82% <100%> (+1.33%)` | `0 <0> (ø)` | :arrow_down: | | [...m/linkedin/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL0NvbnRyb2xsZXJTdGFydGVyLmphdmE=) | `62.71% <100%> (+0.64%)` | `0 <0> (ø)` | :arrow_down: | | [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVhbHRpbWUvU2VnbWVudENvbXBsZXRpb25NYW5hZ2VyLmphdmE=) | `69.12% <33.33%> (+0.06%)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/controller/ControllerLeadershipManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL0NvbnRyb2xsZXJMZWFkZXJzaGlwTWFuYWdlci5qYXZh) | `70% <70%> (ø)` | `0 <0> (?)` | | | [...nkedin/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL1ZhbGlkYXRpb25NZXRyaWNzLmphdmE=) | `34.78% <0%> (-36.24%)` | `0% <0%> (ø)` | | | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `47.85% <0%> (-28.58%)` | `0% <0%> (ø)` | | | ... and [19 more](https://codecov.io/gh/apache/incubator-pinot/pull/3604/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3604?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3604?src=pr&el=footer). Last update [a899cf4...83dba62](https://codecov.io/gh/apache/incubator-pinot/pull/3604?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
