mcvsubbu commented on a change in pull request #3622: Start and stop ControllerPeriodicTasks based on leadership changes URL: https://github.com/apache/incubator-pinot/pull/3622#discussion_r243383383
########## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/periodictask/ControllerPeriodicTaskScheduler.java ########## @@ -0,0 +1,52 @@ +/** + * Copyright (C) 2014-2018 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.linkedin.pinot.controller.helix.core.periodictask; + +import com.linkedin.pinot.controller.ControllerLeadershipManager; +import com.linkedin.pinot.controller.LeadershipChangeSubscriber; +import com.linkedin.pinot.core.periodictask.PeriodicTask; +import com.linkedin.pinot.core.periodictask.PeriodicTaskScheduler; +import java.util.List; + + +/** + * A {@link PeriodicTaskScheduler} for scheduling {@link ControllerPeriodicTask} which are created on controller startup Review comment: This assumes that all ControllerPeriodicTasks are run only on leadership and stopped on non-leadership. Good to document that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
