mcvsubbu commented on a change in pull request #3622: Start and stop
ControllerPeriodicTasks based on leadership changes
URL: https://github.com/apache/incubator-pinot/pull/3622#discussion_r243391097
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/periodictask/PeriodicTaskScheduler.java
##########
@@ -70,11 +73,19 @@ public void start(List<PeriodicTask> periodicTasks) {
}
}
+ /**
+ * Shutdown executor service and stop the periodic tasks
+ */
Review comment:
Perhaps we should differentiate between init/start/stop/shutdown.
init: called on all controllers
start: called when leadership is gained
stop: called when leadership is lost
shutdown: called when controller is shutting down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
