mcvsubbu commented on a change in pull request #3624: [PINOT-7370] Return
number of bytes read from the reader interfaces/implementations
URL: https://github.com/apache/incubator-pinot/pull/3624#discussion_r244791411
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/segment/index/readers/StringDictionary.java
##########
@@ -51,11 +51,15 @@ public String getStringValue(int dictId) {
}
@Override
- public void readStringValues(int[] dictIds, int inStartPos, int length,
String[] outValues, int outStartPos) {
+ public long readStringValues(int[] dictIds, int inStartPos, int length,
String[] outValues, int outStartPos) {
+ long bytesRead = 0;
byte[] buffer = getBuffer();
int inEndPos = inStartPos + length;
for (int i = inStartPos; i < inEndPos; i++) {
- outValues[outStartPos++] = getUnpaddedString(dictIds[i], buffer);
+ String val = getUnpaddedString(dictIds[i], buffer);
Review comment:
same comment as before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
