mcvsubbu commented on a change in pull request #3624: [PINOT-7370] Return
number of bytes read from the reader interfaces/implementations
URL: https://github.com/apache/incubator-pinot/pull/3624#discussion_r246072150
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/io/util/DictionaryDelegatingValueReader.java
##########
@@ -59,6 +59,11 @@ public String getUnpaddedString(int index, int
numBytesPerValue, byte paddingByt
return _dictionary.getStringValue(index);
}
+ @Override
+ public int getUnpaddedStringBytes(int index, int numBytesPerValue, byte
paddingByte, byte[] buffer) {
Review comment:
Why are we returning 'int' for number of bytes here, and 'long' in other
places? Can we just make it long everywhere for consistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
