mcvsubbu commented on a change in pull request #3633: Use
ZkCacheBaseDataAccessor to cache instance configs in PinotHelixResourceManager
URL: https://github.com/apache/incubator-pinot/pull/3633#discussion_r244894617
##########
File path:
pinot-controller/src/test/java/com/linkedin/pinot/controller/helix/PinotResourceManagerTest.java
##########
@@ -66,6 +69,13 @@ public void setUp() throws Exception {
Assert.assertEquals(_helixAdmin.getInstancesInClusterWithTag(HELIX_CLUSTER_NAME,
"DefaultTenant_REALTIME").size(),
1);
+ // Verifying instance configs.
+ ZNRecord znRecord =
_pinotHelixResourceManager.getCacheInstanceConfigsDataAccessor().get("/Server_localhost_0",
null, AccessOption.PERSISTENT);
Review comment:
You should invoke the other method in the test, and compare the result
against getting the instanceconfig directly from helix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
