mcvsubbu commented on a change in pull request #3633: Use
ZkCacheBaseDataAccessor to cache instance configs in PinotHelixResourceManager
URL: https://github.com/apache/incubator-pinot/pull/3633#discussion_r245395131
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -276,7 +292,8 @@ public Builder getKeyBuilder() {
*/
@Nonnull
public InstanceConfig getHelixInstanceConfig(@Nonnull String instanceId) {
- return _helixAdmin.getInstanceConfig(_helixClusterName, instanceId);
+ ZNRecord znRecord = _cacheInstanceConfigsDataAccessor.get("/" +
instanceId, null, AccessOption.PERSISTENT);
Review comment:
pls change the other methods to get instanceconfigs to use the cached
handle. thanks,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
