mcvsubbu commented on a change in pull request #3685: Change the realtime stats
file to a new name
URL: https://github.com/apache/incubator-pinot/pull/3685#discussion_r247297322
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/realtime/impl/RealtimeSegmentStatsHistoryTest.java
##########
@@ -222,9 +222,9 @@ public void testMultiThreadedUse() throws Exception {
// This test attempts to ensure that future modifications to
RealtimeSegmentStatsHistory does not prevent the software
// from reading data serialized by earlier versions. The serialized data has
one segment, with 2 columns -- "v1col1" and
// "v1col2".
- //@Test
+ @Test
public void testVersion1() throws Exception {
- final String fileName = "realtime-segment-stats-history-v1.ser";
+ final String fileName = "realtime-segment-stats-history.ser";
Review comment:
I would retain the old name, because the _contents_ of this file is the
actual V1 contents,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
