mcvsubbu commented on a change in pull request #3685: Change the realtime stats file to a new name URL: https://github.com/apache/incubator-pinot/pull/3685#discussion_r247297276
########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ########## @@ -65,7 +65,7 @@ private RealtimeSegmentStatsHistory _statsHistory; private final Semaphore _segmentBuildSemaphore; - private static final String STATS_FILE_NAME = "stats.ser"; + private static final String STATS_FILE_NAME = "statsV2.ser"; Review comment: Well, we are really not changing the version of the file (in the sense that the formatting, the fields, etc, are the same), So , I would call it something else altogether. "segment-stats.ser" seems ok. Also, please add a comment here that says that the old name used to stats.ser and we had to change it when we move the package to be org.apache ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
