mcvsubbu commented on a change in pull request #3684: Add touch method in
PinotFS; Call touch when moving deleted segments.
URL: https://github.com/apache/incubator-pinot/pull/3684#discussion_r247298157
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java
##########
@@ -248,7 +250,7 @@ public void removeAgedDeletedSegments(int retentionInDays)
{
}
}
} catch (IOException e) {
- LOGGER.error("Had trouble deleting directories",
deletedDirURI.toString());
+ LOGGER.error("Had trouble deleting directories: {}",
deletedDirURI.toString(), e.toString());
Review comment:
Good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
