mcvsubbu commented on a change in pull request #3684: Add touch method in
PinotFS; Call touch when moving deleted segments.
URL: https://github.com/apache/incubator-pinot/pull/3684#discussion_r247298142
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java
##########
@@ -185,6 +185,8 @@ protected void removeSegmentFromStore(String
tableNameWithType, String segmentId
if (pinotFS.exists(fileToMoveURI)) {
// Overwrites the file if it already exists in the target directory.
pinotFS.move(fileToMoveURI, deletedSegmentDestURI, true);
+ // Updates last modified
Review comment:
Please add a comment here that the 'touch' is needed so that
removeAgedDeletedSegments() works correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
