sunithabeeram commented on a change in pull request #3728: Support for
specifying Object Type in Schema
URL: https://github.com/apache/incubator-pinot/pull/3728#discussion_r249438835
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/data/FieldSpec.java
##########
@@ -86,6 +86,10 @@
@ConfigKey("virtualColumnProvider")
protected String _virtualColumnProvider;
+
+ //Complex type that can be constructed from raw bytes stored e.g. map, json,
text
+ @ConfigKey("objectType")
+ protected String _objectType;
Review comment:
Is there a plan to add a PinotObjectFactory that constructs the appropriate
objects based on this type?
Its not clear how String vs enum really helps; enum gives some
enforcement/bounds on the type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
