sunithabeeram commented on a change in pull request #3728: Support for specifying Object Type in Schema URL: https://github.com/apache/incubator-pinot/pull/3728#discussion_r249439328
########## File path: pinot-common/src/main/antlr4/org/apache/pinot/pql/parsers/PQL2.g4 ########## @@ -77,6 +77,7 @@ predicate: | betweenClause # BetweenPredicate | isClause # IsPredicate | regexpLikeClause # RegexpLikePredicate + | matchesClause # MatchesPredicate Review comment: <nit> Would be good to keep this change to just object type changes and bring in the pql changes in a different PR</nit> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
