Jackie-Jiang commented on a change in pull request #3725: Replace partition ranges with partitions URL: https://github.com/apache/incubator-pinot/pull/3725#discussion_r250334110
########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/builder/PartitionAwareOfflineRoutingTableBuilder.java ########## @@ -179,7 +180,8 @@ public synchronized void computeOnExternalViewChange(String tableName, ExternalV } /** - * Get partition id from segment Zk metadata. This helper function assumes there is only one column partition metadata. + * Get partition id from segment Zk metadata. + * TODO: This helper function assumes the segment is partitioned on at most one column, and contains only 1 partition. Review comment: Done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
