Jackie-Jiang commented on a change in pull request #3725: Replace partition
ranges with partitions
URL: https://github.com/apache/incubator-pinot/pull/3725#discussion_r250334872
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/PartitionSegmentPruner.java
##########
@@ -95,25 +94,19 @@ public boolean pruneSegment(FilterQueryTree
filterQueryTree, Map<String, ColumnM
// Leaf node
String column = filterQueryTree.getColumn();
- ColumnMetadata metadata = columnMetadataMap.get(column);
- if (metadata == null) {
- return false;
+ ColumnMetadata columnMetadata = columnMetadataMap.get(column);
+ // NOTE: should have already been pruned in DataSchemaSegmentPruner
Review comment:
That is correct. But if we use this pruner alone (not with
`DataSchemaSegmentPruner`), we should check whether ColumnMetadata exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
