jihaozh commented on a change in pull request #3812: [TE] Refactor detection &
preview API for better debugging
URL: https://github.com/apache/incubator-pinot/pull/3812#discussion_r255645045
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/validators/ConfigValidator.java
##########
@@ -55,7 +55,7 @@ public boolean validateYAMLConfig(String yamlConfig) throws
ValidationException
try {
Map<String, Object> yamlConfigMap = (Map<String, Object>)
YAML.load(yamlConfig);
Review comment:
Looks like this yamlConfig is loaded and thrown away immediately. It should
be fine to let the client code to do validate yaml syntax, cause it has to load
the yaml anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
