xueyumusic commented on a change in pull request #3796: [PINOT-6] Fix Windows
compatibility of a batch of pinot-core tests
URL: https://github.com/apache/incubator-pinot/pull/3796#discussion_r255791346
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/converter/SegmentV1V2ToV3FormatConverter.java
##########
@@ -85,7 +85,10 @@ public void convert(File v2SegmentDirectory)
File newLocation =
SegmentDirectoryPaths.segmentDirectoryFor(v2SegmentDirectory,
SegmentVersion.v3);
LOGGER.info("v3 segment location for segment: {} is {}",
v2Metadata.getName(), newLocation);
- v3TempDirectory.renameTo(newLocation);
+
+ if (!v3TempDirectory.renameTo(newLocation)) {
+ LOGGER.error("cannot rename {} to {}", v3TempDirectory.getName(),
newLocation.getName());
Review comment:
Hi, @mcvsubbu , thank you for review. I think you are right, it looks more
appropriate to throw Exception here. Since it is not related with this
pr(Windows compatible), I revert it back here, will submit a hotfix if
necessary after.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
