xueyumusic commented on a change in pull request #3796: [PINOT-6] Fix Windows
compatibility of a batch of pinot-core tests
URL: https://github.com/apache/incubator-pinot/pull/3796#discussion_r255792928
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/MultipleTreesBuilder.java
##########
@@ -133,4 +133,8 @@ private static SingleTreeBuilder
getSingleTreeBuilder(StarTreeV2BuilderConfig bu
return new OffHeapSingleTreeBuilder(builderConfig, outputDir, segment,
metadataProperties);
}
}
+
+ public void close() {
Review comment:
Hi, @mcvsubbu @sunithabeeram , this is called by `BaseStarTreeV2Test`. Its
real purpose is just to call `MultipleTreesBuilder._segment.destroy()`, since
could not directly get `_segement` of `MultipleTreesBuilder` so add a new close
method...
If `MultipleTreesBuilder._segment` does not destroyed, the
`BaseStarTreeV2Test`'s derived tests such as `MaxStarTreeV2Test` will failed in
tearDown.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
