Jackie-Jiang opened a new pull request #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819 Refactor periodic task to fix the following issues： - PinotTaskManager.scheduleTasks() has no effect on non-leader controller, but returns result from previous run The reason for this is that, we store states for each run as member variables in the periodic task, which mixed the concept of task and run - After calling stop() (lose leadership), when re-gaining leadership, no start() method is called to set up the environment - Potential race condition Move the basic control methods for periodic task (start(), run(), stop()) into BasePeriodicTask Keep table level methods in ControllerPeriodicTask For per-run states, add context generic type to pass them between processing multiple tables
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
