Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task
URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r255829390
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/retention/RetentionManagerTest.java
##########
@@ -92,7 +92,7 @@ private void testDifferentTimeUnits(long pastTimeStamp,
TimeUnit timeUnit, long
conf.setRetentionControllerFrequencyInSeconds(0);
conf.setDeletedSegmentsRetentionInDays(0);
RetentionManager retentionManager = new
RetentionManager(pinotHelixResourceManager, conf, controllerMetrics);
- retentionManager.init();
+ retentionManager.start();
Review comment:
I have the same feeling, but I'm just lazy lol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
