Jackie-Jiang commented on a change in pull request #3819: Refactor periodic task
URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r256181834
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/periodictask/BasePeriodicTask.java
##########
@@ -18,20 +18,39 @@
*/
package org.apache.pinot.core.periodictask;
+import javax.annotation.concurrent.ThreadSafe;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
/**
* A base class to implement periodic task interface.
*/
+@ThreadSafe
public abstract class BasePeriodicTask implements PeriodicTask {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(BasePeriodicTask.class);
+
+ // Wait for at most 5 minutes while calling stop() for task to terminate
Review comment:
Missed a zero. Change comment to 30s. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
